Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filename and asciidoc identifers consistent Comments in nav #1656

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Dec 6, 2024

Port of #1655 to main

cc @rhaetor

@ppalaga ppalaga requested a review from a team as a code owner December 6, 2024 21:59
@ppalaga ppalaga merged commit 3937b3d into quarkiverse:main Dec 11, 2024
26 checks passed
@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 12, 2024

Thanks again for this, @rhaetor.
Your changes merged to the main branch are now online https://docs.quarkiverse.io/quarkus-cxf/dev/
To make sure that all internal links with #fragments work, I have implemented a testing utility. I applied it in this commit

I need to get back to the PR for 3.15 branch

In the future, please send PRs against main. It is typically easier (and a better practice) to backport to a maintenance branch, such as 3.15. Also, please, if possible, create one commit per logical change. Less commits are better for readability of Git history and also for backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants